search

getindata / flink-http-connector

Http Connector for Apache Flink. Provides sources and sinks for Datastream , Table and SQL APIs.
Apache License 2.0
150 stars 42 forks source link

HTTP-92 Customization of HTTP lookup source logger #92

Closed OlivierZembri closed 4 months ago

OlivierZembri commented 5 months ago

The documentation related to Custom request/response callback states that the default SLF4J logger can be overridden by a custom implementation for HttpSink.

There is no such mechanism in place to override the default SLF4J logger for used for HTTP lookup source connector.

This mechanism would be quite useful to change the verbosity of the message and the level at which they are logged thereby avoiding leak of sensible information conveyed by processed events for example.

AdrianVasiliu commented 5 months ago

@kristoffSC @grzegorz8 For enterprise usages, this is a critical need regarding data protection policy. Could you please review, and, if you'll agree with the PR, release a new version to include the new capability?

kristoffSC commented 4 months ago

@OlivierZembri Thank you for this contribution, the time and effort you putted into it. I have merge it to master.

AdrianVasiliu commented 4 months ago

@kristoffSC Thanks a lot! Could you please release this (in 0.14.0)? Please don't wait for some other PR to be merged, we need this very urgently... cc @grzegorz8

kristoffSC commented 4 months ago

@AdrianVasiliu Version is released but there was an issue with maven publish build. Some problems with java doc generation for new classes. I will take a look at it in evening.

AdrianVasiliu commented 4 months ago

@kristoffSC The release seems still unavailable in the maven repo. Can we hope for a short-term solution?

kristoffSC commented 4 months ago

@AdrianVasiliu Hi, 0.14.0 went through, Should be available on maven. I also added https://github.com/getindata/flink-http-connector/pull/97 to that release

AdrianVasiliu commented 4 months ago

@kristoffSC Great, happy about both news, thanks a lot :-) I suppose the availability on maven will take a bit of more time (on maven repo side), for now the artifact isn't yet available.

kristoffSC commented 4 months ago

@AdrianVasiliu I think it may be already available to download via maven (to use as dependency in the project) even though it is not visible on maven-central page.

I've noticed that there is usually around 1, 2 days of delay between publish and when side is updated.

AdrianVasiliu commented 4 months ago

It works now :-) All good, thanks!