search

getindata / flink-http-connector

Http Connector for Apache Flink. Provides sources and sinks for Datastream , Table and SQL APIs.
Apache License 2.0
160 stars 45 forks source link

HTTP-96 Fix logging code in JavaNetHttpPollingClient #97

Closed AdrianVasiliu closed 6 months ago

AdrianVasiliu commented 6 months ago

Description

Resolves #96.

As there are no tests specifically for the logs, the validation of the PR is done manually as follows:

  1. Set the DEBUG level in https://github.com/getindata/flink-http-connector/blob/main/src/test/resources/log4j2-test.properties#L19
  2. mvn clean test -Dtest=JavaNetHttpPollingClientConnectionTest

=> the log contains:

Received status code [201] for RestTableSource request with Server response body [{
  "id": "COUNTER", [...] ]

Without the fix, it is:

Received status code [%s] for RestTableSource request with Server response body [%s]
PR Checklist
kristoffSC commented 6 months ago

Released in 0.14.0