getindata / kafka-connect-iceberg-sink

Apache License 2.0
76 stars 27 forks source link

Double type support #26

Closed waffletower-reify closed 1 year ago

waffletower-reify commented 1 year ago

Description

Added support for double primitive type fields.

PR Checklist

Tests currently assume there is only one potential type identifier, (in this specific casefloat64, for each primitive type. Java reflection is currently used to choose the primitive type identifier. Unfortunately, there appear to be multiple identifiers (float64, double) for the same IEEE 754 64-bit floating point type. I left out explicit unit test support because of this assumption for now. But have tested this version of the sink using debezium acquired sources (which provide the double type identifier).