search

getindata / kedro-kubeflow

Kedro Plugin to support running workflows on Kubeflow Pipelines
https://kedro-kubeflow.readthedocs.io
Apache License 2.0
49 stars 21 forks source link

Resource nvidia.com/gpu Not Handled by ResourceConfig #199

Open cupdike opened 1 year ago

cupdike commented 1 year ago

In kedro-kubeflow 0.7.3, if gpu's are assigned in kubeflow.yaml using an nvidia.com/gpu element, they are not applied to the node as expected in the generated pipeline since they are not handled by the respective ResourceConfig class in config.py: https://github.com/getindata/kedro-kubeflow/blob/0.7.3/kedro_kubeflow/config.py#L181

marrrcin commented 1 year ago

Thanks for reporting this @cupdike , we will fix it soon!

Lasica commented 1 year ago

Sorry didn't mean to close it. I've added the support for custom labels in the resources. It's present in the current develop branch. Could you maybe try if this works for you and report back?

marrrcin commented 1 year ago

@cupdike have you been able to test out the fix provided by @Lasica ?