search

getindata / kedro-kubeflow

Kedro Plugin to support running workflows on Kubeflow Pipelines
https://kedro-kubeflow.readthedocs.io
Apache License 2.0
46 stars 21 forks source link

Volume create does not work with latest kedro-docker image #228

Open marrrcin opened 1 year ago

marrrcin commented 1 year ago

The latest update to kedro-docker (which we've introduced BTW 😀) replaced /home/kedro with /home/kedro_docker due to name collision if someone had __init__.py in their project directory - which is a fine fix. In this plugin however, we still have the /home/kedro path hard-coded e.g. here https://github.com/getindata/kedro-kubeflow/blob/d3cff89ce03e9bcc1b31598a8fa17aadeb2717ab/kedro_kubeflow/generators/pod_per_node_pipeline_generator.py#L177

We need to expose a config for that, so it's settable by the end-user, similarly to kedro-azureml: https://github.com/getindata/kedro-azureml/blob/c220ac31c062d4cceda17b6fcec7053178d47217/kedro_azureml/config.py#L81

szczeles commented 1 year ago

@marrrcin It were not us ;-) https://github.com/kedro-org/kedro-plugins/pull/28

marrrcin commented 1 year ago

Aw, ok 🙈

marrrcin commented 1 year ago

The issue also applies to the feature store_kedro_outputs_as_kfp_artifacts