search

getindata / terraform-azurerm-atlantis

Terraform module for deploying Atlantis in Azure Container Group
Apache License 2.0
8 stars 10 forks source link

Clarification on container image needed to use helpers #18

Open Varantha opened 1 year ago

Varantha commented 1 year ago

Hi there,

Possibly an issue, maybe more a lacking in my understanding.

I am interested in implementing this, I think it's really good! And I see that you have lots of optional helpers available which I may want to use in the future. However my understanding is that those helpers would need to be installed onto the container image before they would work.

I can see that the default image seems to be the main Atlantis repo's image. However wouldn't this need a custom image to work with the helper functions?

I also see that you have a custom image (docker-atlantis) in another repo, which includes the helper components. First I just wanted to check my understanding is correct of the setup. Second, may I suggest an example that uses your docker-atlantis container as the main image? In theory, your complete example shouldn't work as it has the default image with helpers configured... (If I'm understanding correctly?)

jakubigla commented 1 year ago

Thanks for raising this issue @Varantha. We will be looking into this in a very near future as there are other ideas in our backlog to address this issue.

For now what I can say is that you're right - the default Atlantis image doesn't have those dependencies installed, therefore you always need to use a custom image to support the extra functionalities like checkov or infracost.

And as you mentioned docker-atlantis repo contains those dependencies indeed so feel free to use it.