Convert to Typescript - Githubissues

xWTF commented 2 years ago

Changes

This PR converts the plugin to typescript, which provides better auto-completion and type checking for options: Let's use strongly typed JS, because why not :)
It also provides a few JSDoc comment:
The rollup-pluginutils package appears to be replaced by @rollup/pluginutils, the old one was archived on GitHub and haven't received any update for 2 years. So I upgraded the old package to @rollup/pluginutils.

xWTF commented 2 years ago

I see, having a standard ts project structure is better. A few things to note:

I'm not using .npmignore but files in package.json to whitelist all dist files and src files here (ref)
Someone said it's good practice to publish src with your compiled stuff, IDK if it's correct :P
Added javascript-obfuscator and rollup to dev deps to make IDE and tsc happy, since yarn refuses to install peer deps automatically
Currently tsconfig.json will emit source maps to dist folder, is it needed or not?
I suggest to exclude yarn.lock from git repo in 89ccf2a, it causes troubles when you use different registry. I really wonder why yarn devs decide to store registry URL inside the lock file...

getkey commented 2 years ago

Thanks for your patience @xWTF! Great contribution 🥳