getkirby-v2 / panel

This is the deprecated admin panel for Kirby v2.
http://getkirby.com
Other
134 stars 70 forks source link

User profile picture upload doesn't work #13

Closed sashtown closed 10 years ago

sashtown commented 10 years ago

Neither via drag & drop nor via click to upload. Tested in latest stable versions of Chrome, Safari, FF and Opera.

bastianallgeier commented 10 years ago

There's no warning so far if the assets/avatars folder is missing or not writable. Please try to add it and make it writable and let me know if it still doesn't work afterwards.

sashtown commented 10 years ago

Oh, didn't know that. Works perfectly this way! :)

But apart from that it feels a bit wrong to put the avatars in the assets folder though. Cause it's actually (in this very special case) not an asset to the project but more to the Panel. I understand that it shouldn't be part of the Panel folder itself, due to possible update issues in case of newer Panel versions. But maybe we should think about putting the avatars in the root of the content folder. So they'd also be easier to fetch in case of (re)using them as parts of templates (blog posts etc.) optionally in combination with proper meta data (via additional .txt files).

A too complicated approach or what do you think?

bastianallgeier commented 10 years ago

Hm, I haven't considered that. I think it's important to make the root for it adjustable, but I'm not sure if the content folder is the right place. I think it could lead to too many issues, because you would have to exclude it in a couple scenarios (search, sitemap, etc.) Metadata also doesn't really make sense IMHO, since there's already the connected user account, which offers the possibility to add metadata.

sashtown commented 10 years ago

because you would have to exclude it in a couple scenarios (search, sitemap, etc.)

Uhm, you're right. Didn't think of that.

which offers the possibility to add metadata

Got it. Just tried to combine things when it comes to building templates and providing meta data about the users/authors via Kirby's API. Searched for a solution to not having the need of messing around with an avatar for the Panel and another one (maybe exactly the same file and meta data) to provide (some of) the same information (which the Panel user accounts already contain) within a project's template. But I have to admit that my suggestion could lead to unnecessary complications since the Panel user's meta is not stored in globally accessible .txt files but in the site/accounts folder.

Anyhow, I think it'd be helpful to set up an /avatars folder in the upcoming new default theme to avoid that pitfall.

bastianallgeier commented 10 years ago

The idea of adding it to the default theme is great!! In general I'd add the penal by default. I think there are more people who need it than people who don't need it.

AldoFerrari commented 9 years ago

I still have the same issue on Kirby 2.1.1 I run chrome 45 or explorer 11 I'm using the latest version of WAMP with mod_revrite active

I have the avatars folder

afbora commented 9 years ago

I have same issue wamp local server but on live server it's working.