search

getkirby-v2 / toolkit

This is the deprecated toolkit for Kirby v2.
http://getkirby.com
81 stars 50 forks source link

Update docblock. (private->public) #154

Closed vlajos closed 8 years ago

lukasbestle commented 8 years ago

Thanks for the PR, however "private" is correct here. While the method is a public method, it is only be meant to be used internally to retrieve a raw cache value without checking the expiration value.

@bastianallgeier Maybe we should make the method protected in the first place. What do you think?

vlajos commented 8 years ago

Sorry... Although the private is a bit confusing. ("internal" maybe?) (On the other hand, I guess you have higher priority tasks... :-)

bastianallgeier commented 8 years ago

It's actually even in real-world scenario a public method, which can be quite handy to flush the cache programmatically. But thanks for the suggestion! :+1: