search

getkirby-v2 / toolkit

This is the deprecated toolkit for Kirby v2.
http://getkirby.com
81 stars 50 forks source link

Replace DS by '/' on Thumb destination url #165

Closed Ventricule closed 8 years ago

Ventricule commented 8 years ago

Hello, On Windows, since 2.3.0 beta 2 the thumbs was brocken, after a look it seems to be because of a backslash in the thumb url right after '/thumbs'. Exemple : http://localhost/tdc/thumbs\image-800x600.jpg

So, modified thumbs.php line 50 : 'url' => $self->kirby->urls()->thumbs() . DS . $path, replaced by : 'url' => $self->kirby->urls()->thumbs() . '/' . $path, And it rock. Its better like that, right ?

lukasbestle commented 8 years ago

This is a duplicate of getkirby/kirby#436. Have you tried updating to the latest version of the develop branches? Should be fixed there.

Ventricule commented 8 years ago

Yes that's this bug, sorry for the duplicate, thank for the fix! Le 7 mai 2016 14:01, "Lukas Bestle" notifications@github.com a écrit :

This is a duplicate of getkirby/kirby#436 https://github.com/getkirby/kirby/pull/436. Have you tried updating to the latest version of the develop branches? Should be fixed there.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/getkirby/toolkit/issues/165#issuecomment-217631572

lukasbestle commented 8 years ago

No problem, thanks for confirming.