search

getkirby-v2 / toolkit

This is the deprecated toolkit for Kirby v2.
http://getkirby.com
81 stars 50 forks source link

Fixed wrong comparison #180

Closed ezraverheijen closed 8 years ago

ezraverheijen commented 8 years ago

$strict should always be the default to cover cases where attributes might be unquoted or quoted illegally (e.g. backticks are valid quotes for IE)

lukasbestle commented 8 years ago

Could you please remove the second commit from this PR again via a force push? Otherwise this one PR will have two separate changes. The other PR (#191) will be considered.

lukasbestle commented 8 years ago

Now the other PR is closed, that was the wrong way around. :)

ezraverheijen commented 8 years ago

I see what happened. I did not notice there were actually two PR's. Best practice now? Drop this PR to and start over?

lukasbestle commented 8 years ago

Well, probably. You should use separate branches for your two PRs to keep them separate.