search

getkirby-v2 / toolkit

This is the deprecated toolkit for Kirby v2.
http://getkirby.com
81 stars 50 forks source link

Mailto link does not work - E-Mail Addresses are double obfuscated #200

Closed texnixe closed 7 years ago

texnixe commented 7 years ago

https://forum.getkirby.com/t/kirby-2-4-0-are-e-mail-addresses-double-obfuscated/5727

lukasbestle commented 7 years ago

I found the issue: The htmlspecialchars() in this line is responsible for it.

Looks like the same change is also the reason for other issues. Because the change itself is useful, I don't think simply reverting would help. @bastianallgeier?

bastianallgeier commented 7 years ago

@lukasbestle I agree! It's simply more secure that way. I think I already fixed all the field issues and I just introduced a new way of defining unescaped attributes to also fix this issue. I think it's more reasonable to give this option, but still keep the default more secure.