Change thumb->settingsIdentifier() to include all options and all option values instead of only a specific whitelist of values.
I had to excluding the destination option as it type can't be converted to a string. Might be a nicer way to check that, but wasn't sure it'd be necessary.
Reasoning
Background: I have a custom thumb driver, which includes some extra advanced options for ImageMagick. E.g. an option to add the "flatten" command, to create a still from a GIF. I also have my config set to include the {hash} in the filename:
Given that scenario, if I create a "flattened" and "unflattened" thumbnail at the same size, they'll both get the same filename (including hash). Seems like a logical way to insure the filenames never collide is to include all the options.
Changes
Change
thumb->settingsIdentifier()to include all options and all option values instead of only a specific whitelist of values.I had to excluding the
destinationoption as it type can't be converted to a string. Might be a nicer way to check that, but wasn't sure it'd be necessary.Reasoning
Background: I have a custom thumb driver, which includes some extra advanced options for ImageMagick. E.g. an option to add the "flatten" command, to create a still from a GIF. I also have my config set to include the
{hash}in the filename:Given that scenario, if I create a "flattened" and "unflattened" thumbnail at the same size, they'll both get the same filename (including hash). Seems like a logical way to insure the filenames never collide is to include all the options.