search

getkirby-v2 / toolkit

This is the deprecated toolkit for Kirby v2.
http://getkirby.com
81 stars 50 forks source link

suggestion: automatic ace conversion for redirects #232

Closed bnomei closed 7 years ago

bnomei commented 7 years ago

using header redirect to an url with german umlaut does not work. one needs to convert to ace using idn_to_ascii(). a simple check might be comparing $url and htmlentities($url).

since toolkit redirect is used kirbys go() helper and the v::url() and url panel field accepts idn formatted urls (with german umlaut) one might expect this to work out of the box, but it does not.

so maybe the toolkit redirect class could be extended to handle idn formated urls automatically.

example url in case you don't have one in mind: http://architekturgespräche.de

lukasbestle commented 7 years ago

This is now implemented on the develop branch along with other improvements to IDN handing.