search

getkirby-v2 / toolkit

This is the deprecated toolkit for Kirby v2.
http://getkirby.com
81 stars 50 forks source link

Fix size helper for file sizes #243

Closed distantnative closed 7 years ago

distantnative commented 7 years ago

Otherwise only the size of the path string will be returned

Or am I wrong?

lukasbestle commented 7 years ago

Actually I'm not so sure if it is a good idea to have support for file size in this helper. After all the string you want the length of could be the name of an existing file by accident. So we should maybe remove this feature all-together. As it never worked, we won't break anything.

distantnative commented 7 years ago

You got a good point there.

lukasbestle commented 7 years ago

I am going to remove support for file sizes in 2.5.3 and am therefore closing this.