getkirby / editor

A new type of WYSIWYG editor for Kirby
https://getkirby.com
205 stars 28 forks source link

TypeError after deleting video block #239

Closed moritzebeling closed 4 years ago

moritzebeling commented 4 years ago

Describe the bug When deleting a video block, something happens, that would’t let you open the block-menu of another block.

To Reproduce Steps to reproduce the behavior:

  1. Have an editor field containing at least two blocks, one (Vimeo) video and one other, e.g. text block.
  2. Delete the video block using the arrow down button left to the video preview.
  3. Now try to use the arrow down menu of the remaining block.
  4. Once you click that, an error appears which leaves the user unable to continue editing.

Screenshots Delete video block:

Bildschirmfoto 2020-06-08 um 13 01 52

Try to use other block menu:

Bildschirmfoto 2020-06-08 um 13 02 20

Error appears:

Bildschirmfoto 2020-06-08 um 13 03 02

Kirby Version Kirby 3.3.6 Editor 1.0.0

Console output

TypeError: undefined is not an object (evaluating 'this.$refs.settings.open')
  menu — index.js:1:236974
  menu
  (anonyme Funktion) — index.js:1:245020
  open — index.js:1:12143
  open
  mousedown — index.js:1:12932
  oe — vendor.js:41:11764

Desktop (please complete the following information): macOS Safari 13.1 + Chrome 83

bastianallgeier commented 4 years ago

I cannot reproduce this with the latest editor version. I believe this is already fixed. Please upgrade and feel free to reopen if it still happens.