search

getkirby / getkirby.com

Source code and content for the Kirby website
https://getkirby.com
131 stars 266 forks source link

Move to CDN #2318

Closed bastianallgeier closed 4 months ago

lukasbestle commented 4 months ago

Those last commits came from a systematic Lighthouse check of our templates. Typical “while I was at it”. I included those in the develop branch so I could verify the results with the CDN. But of course not suitable for a PR review.

I can take that contrast commit out of the branch and create a separate PR. Makes it easier to review because we will see all changed places with those gray boxes.

About the variable name: Maybe --color-text-dimmed-dark? It’s quite long but IMO at least obvious about its purpose next to the existing variables.

bastianallgeier commented 4 months ago

I think it's fine. Let's move more utility changes to another PR. It's good that the a11y issues are fixed by this and it's no big deal to adjust it some more later.

bastianallgeier commented 4 months ago

Ironically, now you have to approve your own PR, because I've created it 🤣

lukasbestle commented 4 months ago

Will merge it manually