getkirby / getkirby.com

Source code and content for the Kirby website
https://getkirby.com
125 stars 260 forks source link

Refactor KeyCDN thumb handling #2328

Closed lukasbestle closed 2 weeks ago

lukasbestle commented 3 weeks ago

Description

Summary of changes

Reasoning

Additional context

Relevant docs: https://www.keycdn.com/support/image-processing

lukasbestle commented 2 weeks ago

About the method order: I agree it would be good to use a consistent pattern in the whole team. What I like about having public methods first is that it allows to see at a glance what I can do with a class. Whereas finding a specific method is easy with Cmd-R in VS Code and similar tools in other IDEs.