search

getkirby / ideas

This is the backlog of ideas and feature requests from the last two years. Use our new feedback platform to post your new ideas or vote on existing ideas.
https://feedback.getkirby.com
20 stars 0 forks source link

"Search" Core Component Should Allow for Not Using a Site Index #570

Closed neildaniels closed 4 years ago

neildaniels commented 4 years ago

As an augmentation to https://github.com/getkirby/kirby/pull/2369, it would be nice to signal to Kirby that a site()->index() should not be performed.

https://github.com/getkirby/kirby/blob/eafb118fe4a221fbf1c684e0b87bcf1c51549376/config/api/routes/site.php#L63-L78

My current site has a rather large page set (including lots of virtual pages) and on my local dev environment, fetching a complete index literally exhausts all available memory on Docker and the call fails.

I was hopeful that https://github.com/getkirby/kirby/pull/2369 would allow me to decide exactly what pages are even considered to be searchable. For front-end site searches, I keep a separate index of page titles (mapped to their page id); it would be nice to be able to truly leverage that for Panel searches as well.

bastianallgeier commented 4 years ago

That's a good point! We see what we can do for 3.4. Otherwise we will try to fix this later.

bastianallgeier commented 4 years ago

I just discussed this with @distantnative and the search component is really intended to overwrite the search filter for collections. It's not meant to replace the entire site()->index() logic. If you want to do that you can replace the API route with a custom one and make sure that you run your own search logic in there. But we've added to our todo list to find a better global way of handling search in general in a later release.