Closed lukasbestle closed 5 years ago
my 2c
minimum-requirement: "beta"
from composer.json
composer.json
data where possible. i think the support should be a quiet obvious choice."optimize-autoloader": true
or something like a "kirby-update" composer script by default which does composer update; composer dumpautoload -o;
see Autoloader OptimizationThanks for your input, I have amended it to the first post.
add composer.json data where possible. i think the support should be a quiet obvious choice.
We already have the support
key in our composer.json
. However I think we shouldn't make the composer.json
too complex because all of that needs to be maintained. So we are focussing on the fields that are most useful.
maybe you have usecases for event-triggered skripts like displaying a changelog post update
If every package did that, the Composer output would get very very confusing. Maybe later if we really have a use-case for such a script, but not just "because we can". :)
you could feature top10 plugins (counting stars) in the suggested data
Again we would need to maintain that and also it produces a lot of output to the Terminal. Let's keep it simple. Most important is that installation with Composer works and works reliably.
@lukasbestle you are right. i did not think about terminal output and dependencies. simple is better.
Could I also kindly put a request for:
✅
A little checklist of what we still need to do for proper Composer support:
Can be done now:
.gitattributes
file to exclude tests, scripts and config dotfiles from the ZIP exportdist
folder to the repo (don't ignore it in.gitignore
)composer.json
to the Starterkit so thatcomposer create-project
works"optimize-autoloader": true
by defaultk-next/composer-repo
repo (not needed anymore)composer-installer
repocomposer create-project getkirby/starterkit
Needs to be done with the first public release:
"minimum-stability"
in allcomposer.json
filescomposer.json
of thekirby
package (undo https://github.com/k-next/kirby/commit/efea0db6dfa1d1eea7f5289f5597029fdbe3d9e6)kirby
package on Packagistcomposer-installer
package on Packagiststarterkit
package on Packagistreleases
repo without source files but with vendor files and commit each release to it for use with a Git submodule installation