getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.32k stars 168 forks source link

Replace umlauts correct #1130

Closed timoreddig closed 6 years ago

timoreddig commented 6 years ago

If you create a new page, in my opinion the german umlauts ä, ö, and ü will not be replaced correctly. Instead of a, o an u it should be ae, oe and ue.

before:

bildschirmfoto 2018-10-24 um 22 03 20

after:

bildschirmfoto 2018-10-24 um 22 03 56

lukasbestle commented 6 years ago

Thank you for reporting that issue.

We had a similar issue in Kirby 2, but the other way around (see https://github.com/getkirby/panel/issues/773). The same characters that are used as Umlauts in German are also used in other languages (like Turkish) and need to be converted differently there.

Replacing all accented characters with just their base character is therefore probably the safest way for most languages.

However it should be possible to customize that ASCII translation table from plugins and/or the config. In Kirby 2 that was easily possible. However I can't say right now if it is also already possible in Kirby 3.

timoreddig commented 6 years ago

@lukasbestle thank your for your information. It´s ok for me. I´ll close the issue.