Closed distantnative closed 2 years ago
Komments and Commentions need to be added as well.
Thanks, I added them to the list above.
Image Clip also.
@mynameisfreedom Thanks, added to list.
@MaluNoPeleke Added to list.
These two as well:
rasteiner/k3-pagesdisplay-section#9 texnixe/k3-filesdisplay-section#3
These have been fixed and Commentions and Komments have already updated branches for 3.6 (but not released yet officially).
I've updated the list.
my mailjet plugin as some views as well but can be considered low priority (if any): https://github.com/bnomei/kirby3-mailjet/tree/master/src/components
Added to list.
I am still working on this: https://github.com/mauricerenck/kirby-podcaster
As someone who has just released a custom panel view plugin, is it going to break in 3.6? I'm assuming this is related to the new Fiber system?
Edit: Maybe I should just go test it myself 😅
@PaulMorel Unfortunately yes: https://getkirby.com/releases/3.6/breaking-changes#panel__custom-panel-views
@afbora Is it feasible to have my plugin compatible with both 3.6 and older versions? Or is this a headache waiting to happen?
@PaulMorel You can use releasement. For example: v0 is <=3.5
, v1 is >=3.6
@PaulMorel I have just worked on an update for my Versions plugin, which also uses a view.
You can actually both register the view in the frontend for older versions and register an area in the backend for 3.6+. 3.6 will ignore the view defined in the frontend and 3.5 and previous versions will ignore the area. Unless your code runs into other breaking changes, you can make an update to your plugin that supports both scenarios.
image-clip (develop branch) works now with beta2
@mullema Great! I've updated the list.
Report : SimpleStats works with the new develop 3.6 branch. :)
Note: I came trough an undocumented (3.6) breaking change (namespace issue) : is_a($page, 'Page')
returns false
after updating from 3.5.?
to 3.6-beta-3
.
Fix: is_a($page, 'Kirby\Cms\Page')
@Daandelange I've tested is_a($page, 'Page')
returns true
for homepage on 3.6.0-beta.3. Can you share more detailed information please?
I just stumbled over an incompatibility in Uniform Plugin: https://github.com/mzur/kirby-uniform/issues/219
@ralfgoeke Thanks, I've added to list.
@afbora My use case is in a route::after
hook, while visiting a Page object.
Same result printing it in a page template. Using php 7.4.2 locally on os x.
// use Kirby\Cms\Page; <-- Result with namespace declaration : bool(true) bool(true) bool(false) bool(true)
App::plugin('daandelange/simplestats', [
'hooks' => [
'route:after' => function ($result) {
var_dump( is_a($result, 'Kirby\Cms\Page'), $result instanceof Kirby\Cms\Page, is_a($result, 'Page'), $result instanceof Page, $result);
die();
}
]
]);
Result: bool(true) bool(true) bool(false) bool(false) object(Kirby\Cms\Page)#584 (15) [...]
Is there a way to detect the Kirby version in a plugin? As Kirby 3.6 is a "minor" release, I'd like to keep compatibility for all 3.x versions. My plugin will break with the new Str::template
arguments and all I would need to do is use different arguments for <=3.5 than >=3.6.
@mzur You can use Kirby::version()
to get installed version.
Thanks. You can move Uniform to "Done" now.
The Helpsection Plugin now works fundamentally. https://github.com/amteich/kirby-helpsection/releases/tag/2.0.0
I would like to integrate routing for the subpages. Can anybody show me how or create a pullrequest?
Can somebody help me with integrating this Babel Plugin to make syntax highlighting work fully again: https://github.com/mAAdhaTTah/babel-plugin-prismjs?
Hi
there is work in progress for the Custom Add Fields Plugin
at https://github.com/steirico/kirby-plugin-custom-add-fields/tree/feature/kirby-3.6
Here is another one WIP that could need some support: https://github.com/flokosiol/kirby-translations/tree/kirby3
@PaulMorel I have just worked on an update for my Versions plugin, which also uses a view.
You can actually both register the view in the frontend for older versions and register an area in the backend for 3.6+. 3.6 will ignore the view defined in the frontend and 3.5 and previous versions will ignore the area. Unless your code runs into other breaking changes, you can make an update to your plugin that supports both scenarios.
Thanks @lukasbestle, That's exactly what I ended up doing. Registering the area for 3.6+ worked fine and I had very little changes to do for it to still work in 3.5.
Can you pease add this plugin to the list?
@MaluNoPeleke I've added to the list.
Markdown Field: https://github.com/sylvainjule/kirby-markdown-field/issues/116 (issue refers to the next
branch in active development; haven't tested the current stable version with 3.6, yet)
Just for completeness, updating the info in the original post on top: Commentions is now 3.6-compatible in newly released versions on both the stable branch (v1.0.5) and the WIP v2.0 branch (v2.0-beta.4).
Komments latest release (and main branch) is now 3.6 compatible and 3.5 "backward" compatible.
Kirby Podcaster now works with 3.6
Can you pease add this plugin to the list?
Can be removed as I cannot reproduce anymore after latest plugin update
Trying to migrate my OAuth Plugin to 3.6. I hooked into the Vue Router to prevent a redirect to the install view so you can still login with a valid OAuth user even when there is no user created yet.
// always route back to panel home when trying to access installation view
if (panel?.app?.$route?.path === "/installation") {
panel.app.$go("/");
}
// prevent routing to the installation view (e.g. like the login view does)
panel?.app?.$router?.beforeEach((to, _, next) => {
if (to.path !== "/installation") next();
});
https://github.com/thathoff/kirby-oauth/blob/kirby-3.6/src/index.js#L12
Any hints on how to accomplish this with Kirby 3.6?
Komments latest release (and main branch) is now 3.6 compatible and 3.5 "backward" compatible.
I always get a error 500 after installing it on Kirby 3.6 RC.3 without any additional information (debugging turned on).
Komments latest release (and main branch) is now 3.6 compatible and 3.5 "backward" compatible.
I always get a error 500 after installing it on Kirby 3.6 RC.3 without any additional information (debugging turned on).
Would you be so nice and create an issue in the komments github repo? This is more in my focus, I will have a look at it. Maybe with some additional info about your setup. That would be nice.
https://github.com/sylvainjule/kirby-pagetable I've merged the 3.6 support into the latest release
I'm looking into the bouncer plugin next week!
Can you add this plugin and maybe offer support to make it compatible with Kirby 3.6 again?
@MaluNoPeleke This plugin has nothing to do with the changes introduced in 3.6, it wasn't compatible with 3.5 either. Let's not mix things up.
Oh, sorry, sure.
Let's collect a list of plugins we know 3.6 will break (and where we could send PRs or give tips how to update):
Done
feature/kirby-3-6
branch is compatible with 3.6: https://github.com/mauricerenck/komments/tree/feature/kirby-3-6develop
branch is compatible with 3.6: https://github.com/sebastiangreger/kirby3-commentions/tree/developdevelop
branch: https://github.com/mullema/k3-image-clip/tree/developvue-router
and store modules heavilyPlease feel free to edit this post, so we have the full list always on top.