getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.27k stars 167 forks source link

[3.6.0-alpha.3] Missing main top navigation bar on custom areas #3618

Closed afbora closed 3 years ago

afbora commented 3 years ago

Describe the bug

https://getkirby.com/releases/3.6/fiber/areas#area-definition

I've tried custom area definetion like above example, but panel main top navigation bar is missing.

index.js

panel.plugin('yourname/todos', {
  components: {
    'k-todos-view': {
      props: {
        todos: Array
      },
      template: `
          <k-view class="k-todos-view">
            <k-header>
                Todos
            </k-header>
          </k-view>
        `
    }
  }
})

Screenshots

screen-capture-1138-Theme Options - Mægazine-localhost

Kirby Version

3.6.0-alpha.3

distantnative commented 3 years ago

You have to wrap your custom view with <k-inside>

afbora commented 3 years ago

Ahh, working now! But this information should be clearly in Custom Panel Views section of breaking changes page

afbora commented 3 years ago

Related PR https://github.com/getkirby/getkirby.com/pull/1454

distantnative commented 3 years ago

👍