Closed distantnative closed 3 years ago
These calls have no effect anymore.
It used to be that k-error-dialog automatically displays itself if there is an error notification set in the store: https://github.com/getkirby/kirby/blob/main/panel/src/components/Dialogs/ErrorDialog.vue
k-error-dialog
The component got refactored to work for Fiber responses that return an error: https://github.com/getkirby/kirby/blob/develop/panel/src/components/Dialogs/ErrorDialog.vue
However, the whole notification store logic was completely dropped and also not moved to any other part of the Panel code. We need to reintroduce that logic.
✅
bastianallgeier
commented
3 years ago
These calls have no effect anymore.
It used to be that
k-error-dialogautomatically displays itself if there is an error notification set in the store: https://github.com/getkirby/kirby/blob/main/panel/src/components/Dialogs/ErrorDialog.vueThe component got refactored to work for Fiber responses that return an error: https://github.com/getkirby/kirby/blob/develop/panel/src/components/Dialogs/ErrorDialog.vue
However, the whole notification store logic was completely dropped and also not moved to any other part of the Panel code. We need to reintroduce that logic.