getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.32k stars 168 forks source link

Image in Layouts can't be added or selected (3.6 rc4) #3924

Closed lexislav closed 3 years ago

lexislav commented 3 years ago

Describe the bug
Image field inside Layouts can't be edit now - clicking the add button opens the dropwdown (select, upload) but both choices do nothing.

To Reproduce
Add image to layout. Click on image to edit image field. Click add image - try to upload or select…

Expected behavior
Click on select/change image in panel opens the dialog to do the action.

Kirby Version
Kirby 3.6 r.c.4

Desktop (please complete the following information):

afbora commented 3 years ago

Is this a safari specific bug? 🤔 I couldn't reproduce the issue on Chrome 95 & Firefox 93 & Windows 10.

afbora commented 3 years ago

@lexislav Is there any output on console?

lexislav commented 3 years ago

I have tried on macOS with Chrome and Firefox - the same. This dropdown doesn¨t work:

But no error on console.

When existing image is removed from field, clicking on filed shows this error - this.$refs.options.toggle is not a function:

This is also shown on console:

index.js:1 TypeError: this.$refs.options.toggle is not a function at a.prompt (index.js:1) at Vt (vendor.js:6) at HTMLButtonElement.n (vendor.js:6) at HTMLButtonElement.i._wrapper (vendor.js:6)

10. 11. 2021 v 15:16, Ahmet Bora @.***>:

@lexislav https://github.com/lexislav Is there any output on console?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/getkirby/kirby/issues/3924#issuecomment-965242909, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWQ6VMPDF3PJJMNXBE32Z3ULJ5CVANCNFSM5HX7HS7Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

bastianallgeier commented 3 years ago

Hm, I just tried and I'm also not able to reproduce this at all. This is weird.

lexislav commented 3 years ago

The bug was not on the fresh install, but on a site I have tried to update from Kirby 3.5.7.

After transfering all site's blueprints, content, configs to the fresh install of rc4, the issues is gone. So that is wierd indeed.

11. 11. 2021 v 13:26, Bastian Allgeier @.***>:

Hm, I just tried and I'm also not able to reproduce this at all. This is weird.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/getkirby/kirby/issues/3924#issuecomment-966262078, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWQ6VIPKH4RXFNUWXUFXI3ULOZBFANCNFSM5HX7HS7Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

bastianallgeier commented 3 years ago

Maybe something got messed up in the cache. I think we will never know :) Thanks for taking the time to upgrade everything!

zakgreene commented 2 years ago

I'm having the same issue after upgrading from 3.5.4 via composer, can't select or upload images across the site. Same errors, this.$refs.options.toggle is not a function when clicking any image field, same output to console from index.js.

zakgreene commented 2 years ago

Tried a fresh install, uploading worked until I copied my project files (content, templates, blueprints, controllers, languages, plugins). I disabled plugins, disabled languages, and uploading on a Files section worked when I disabled languages, but not as part of a layout image subfield. Looks like I'll have to downgrade unfortunately.

afbora commented 2 years ago

@zakgreene Do you have a chance to share your project with us as you got the error to close look? To e-mail: support@getkirby.com

thisissasa commented 2 years ago

has also happend for me after upgrading to kirby 3.6.2. It seems to be triggered by the retour plugin (3.0.0)