search

getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.27k stars 167 forks source link

[3.7.0-rc.1] Upload icon missing from files section #4368

Closed medienbaecker closed 2 years ago

medienbaecker commented 2 years ago

Description

The upload icon has been replaced with a plus icon. I guess this was a mistake?

CleanShot 2022-06-14 at 21 24 50@2x

Expected behavior
The upload icon should be shown like in earlier releases. This way there's a visual distinction between selecting and uploading files (files section vs files field).

CleanShot 2022-06-14 at 21 24 27@2x

To reproduce

  1. Add a files section
  2. Look at the icon

Your setup

Kirby Version
3.7.0-rc.1

afbora commented 2 years ago

This appears to be the case because the pages and files sections are combined into a common component as ModelsSection.vue and this is related commit https://github.com/getkirby/kirby/commit/d39f3521e18135b99fe329b6d3669a8be4463963

Pinging @distantnative to ask is this mistake or intended?

distantnative commented 2 years ago

Mistake!

distantnative commented 2 years ago

Will be fixed in RC2 ✅