getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.32k stars 168 forks source link

Tags field should hide "Add" button when disabled #5723

Closed chinochano closed 1 year ago

chinochano commented 1 year ago

Description

The tags field has the ability to query tags from other fields or pages and allow the user to select from those values. When adding tags on the fly is disabled, the Add button doesn't disappear which is confusing.

Expected behavior
When using the tags field with accept: options, the "Add" button and also the "Create" button should disappear.

Screenshots
Screenshot 2023-10-03 at 11 06 15 Screenshot 2023-10-03 at 11 15 48

Add a tag field using this code:

years:
  type: tags
  accept: options
  options: query
    type: query
    query: page('people').yeartags.split # replace for a working query

Your setup

Kirby 4 Beta 1

afbora commented 1 year ago

I can't reproduce the issue on beta.2 with following setup:

tags:
  type: tags
  accept: options
  options: query
  query:
    fetch: site.tags.split