[v4] Selecting spesific custom `writerMarks` doesn't work

[afbora]

I'm not sure this is a bug or I'm missing some setup. Selecting spesific custom writerMarks doesn't work for writer field.

Plugin

panel.plugin("my/writer-mark", {
  writerMarks: {
    smile: {
      get button() {
        return {
          icon: "smile",
          label: "Smile"
        }
      }
    }
  }
});

Blueprint

fields:
  writer:
    type: writer
    marks:
      - bold
      - smile
    toolbar:
      inline: false
      marks:
        - bold
        - smile

Result

Additional Context

I can see the button when marks: true

fields:
  writer:
    type: writer
    marks: true
    toolbar:
      inline: false

Kirby 4.0.0-beta.2

[afbora]

As workaround, all custom writer mark plugin should has name getter like following. I've fixed in this PR https://github.com/getkirby/kirby/pull/5733

panel.plugin("my/writer-mark", {
  writerMarks: {
    smile: {
      get name() {
        return "smile"
      },
      get button() {
        return {
          icon: "smile",
          label: "Smile"
        }
      }
    }
  }
});

[distantnative]

@afbora The fix could also be in our plugin registry to inject this getter for any custom Maribor node that does not define it itself

[afbora]

@distantnative I don't know exactly what you mean by "Maribor node". Do you mean the writerNodes extension where we register the custom nodes for writer field?

[distantnative]

I shouldn't write from y phone 🙈 "for any custom mark or node"