search

getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.32k stars 168 forks source link

[v4] Blocks field: links can't be clicked in help text with preview and wysiwyg option #5880

Closed afbora closed 1 year ago

afbora commented 1 year ago

Description

name: Test block
preview: fields
wysiwyg: true
fields:
  text:
    type: text
    help: >
        Try to <a href='https://getkirby.com/' target="_blank">Click here</a>.

To reproduce

  1. Create custom block with sample above blueprint
  2. Add this block type to the field
  3. Try to click to link in help text
  4. See nothing happened

Your setup

Kirby Version
Beta.2

distantnative commented 1 year ago

I think this is the culprit

@click.native.prevent.stop="onClickBlock(block, $event)"

https://github.com/getkirby/kirby/blob/v4/develop/panel/src/components/Forms/Blocks/Blocks.vue#L34

Would think that we need to remove the .prevent part while keeping .stop - but we will need to test all the other scenarios, if they still work then.

afbora commented 1 year ago

Yes. It is working without prevent. So what exactly does prevent do? What scenarios are we going to test?

distantnative commented 1 year ago

It's part of this PR https://github.com/getkirby/kirby/pull/5884

In terms of testing especially these https://github.com/getkirby/kirby/issues/5626 and https://github.com/getkirby/kirby/pull/5840 that we just fixed before.