getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.23k stars 166 forks source link

Changing the sort number of listed pages will cause recreation of image source sets #6508

Open ovenum opened 6 days ago

ovenum commented 6 days ago

Description

Changing the page number of a listed page that has already created source set image version in /media/pages will cause a recreation of the already created images under a different path.

Expected behavior

Kirby should not re-create those images because their path and original file did not change.

This can cause problems for image heavy sites where source sets are created after image upload and not on requests. Also see issue #5328 why this has the potential to take a site offline although source sets have been pre-created to avoid this issues.

I noticed that Kirby seems to include the modified timestamp of the page the images belongs to in the FileVersion url. Which could be the reason copies are created.

To reproduce

image

Your setup

Kirby Version
Kirby 4.3.0