getkirby / kirby

Kirby's core application folder
https://getkirby.com
Other
1.31k stars 168 forks source link

Panel: Icon stroke and size inconsistency #6663

Closed nilshoerrmann closed 1 month ago

nilshoerrmann commented 1 month ago

Description

We are working on a panel plugin and a section with the following button group:

            <k-button-group layout="collapsed" class="k-tracker-date">
                <k-button
                    icon="calendar"
                    variant="filled"
                    :dropdown="true"
                    size="xs"
                    @click="$refs.statsRange.toggle()"
                >
                    {{ labelRange }}
                </k-button>

                <k-dropdown-content
                    ref="statsRange"
                    :options="dropdown"
                    theme="light"
                    align-x="end"
                />

                <k-button icon="angle-left" size="xs" variant="filled" />
                <k-button icon="angle-right" size="xs" variant="filled" />
            </k-button-group>

This creates inconsistent icon proportions and stroke widths:

grafik

Expected behavior
The chevrons should match in size and stroke. Judging other areas of the system, it looks as if the dropdowns icon is to small and thin. But maybe the middelground would be better for extra small sized buttons: stronger strokes for the dropdown but an icon size between the to existing.

Your setup

Kirby Version
Latest version.

distantnative commented 1 month ago

I think this is a deliberate design choice to have the dropdown arrow rendered in a smaller, less dominant way compared to the main button icons (here: calendar, angle-left, angle-right).

nilshoerrmann commented 1 month ago

Okay, this might boil down to personal preference but I think the down pointing chevron is even too thin compared to the font weight. Feel free to close this though, if you think this is just fine in context of your design system.