getkirby / staticache

Static site performance on demand
MIT License
90 stars 9 forks source link

ignore cache keys that are not page ids #21

Closed bnomei closed 1 year ago

bnomei commented 1 year ago

if the page object here is null then return early. this allows other code to hijack the pages cache and add key-value that do not relate to a real page object. like sitemaps. why hijack? so these cache values get flushed when the pages cache does.

https://github.com/getkirby/staticache/blob/9ef2d7195b5c8212fcf53194407cc28aec0e3901/src/StatiCache.php#L107

bnomei commented 1 year ago

oh my. duplicate of this. https://github.com/getkirby/staticache/issues/20#issuecomment-1442429831