search

getlago / lago-api

Open Source Metering and Usage Based Billing
https://www.getlago.com/
GNU Affero General Public License v3.0
337 stars 99 forks source link

[FEAT]: Karafka 2.4.0 + WaterDrop Breaking Changes #1966

Closed mensfeld closed 6 months ago

mensfeld commented 6 months ago

Is your feature request related to a problem? Please describe.

Hey :wave: . I'm Maciej. Karafka author. I just wanted to give you a heads-up that Karafka 2.4 contains some breaking changes. There is no immediate need of upgrade as there are no bigger issues that were fixed but not backported, though at some point you may want to consider an upgrade.

https://karafka.io/docs/Upgrades-2.4/

Describe the solution you'd like

The solution in a long term would be to upgrade :)

Describe alternatives you've considered

Not upgrading and being sad.

Additional context

https://karafka.io/docs/Upgrades-2.4/ https://mensfeld.pl/2024/04/karafka-2-4-release-announcement-advancing-kafka-processing-for-ruby-and-rails/

jdenquin commented 6 months ago

thanks @mensfeld, since we don't use karafka in production right now I'll do the update

mensfeld commented 6 months ago

Please be mindful of waterdrop changes as well. While all of the settings I changed are changed "for better" it is better to be aware :)

Since you are now aware I will consider this resolved.