search

getlantern / browsersunbounded

Interoperable browser-based P2P proxies for censorship circumvention
GNU General Public License v3.0
11 stars 0 forks source link

Migrate Broflake telemetry to OTLP metrics in DD #136

Open lincolnmantracer opened 1 year ago

lincolnmantracer commented 1 year ago

Hey @noahlevenson, I know you're currently using Honeycomb with OTLP metrics (or traces). I'd like to migrate those to datadog, which I think will give you a much nicer experience. It should hopefully be relatively easy because we can just point them at a different place, but maybe we could have a ten minute huddle about it when you have a chance?

noahlevenson commented 1 year ago

For sure. We should use the session to talk about https://github.com/getlantern/broflake/issues/113 too.

I'll drop you a meeting invite just to mark some time.

noahlevenson commented 1 year ago

Note to self:

Hey nelson, you're going to point the collector env vars to ops.iantem.io:443. But before you do that, for god's sake, make sure you do the following:

  1. Rename all the metrics obeying the right naming conventions: https://opentelemetry.io/docs/reference/specification/metrics/semantic_conventions/

  2. Change the bytes gauge to a monotonic instrument with "temporality selector." See: https://github.com/getlantern/lantern-cloud/blob/c57ff5d721871ed90c2fc3e429c8a64039bae34f/metrics/metrics.go#L22-L33

  3. Make sure you don't use labels so we don't have any cardinality issues!

Don't screw it up.