search

getlantern / browsersunbounded

Interoperable browser-based P2P proxies for censorship circumvention
GNU General Public License v3.0
14 stars 0 forks source link

Get Freddie metrics working on Datadog #205

Closed noahlevenson closed 10 months ago

noahlevenson commented 10 months ago

Edit 11/22/2023: It's come to our attention that Freddie's metrics just aren't working the way we expect on Datadog. For example, we observe values going negative, which shouldn't happen. It seems like maybe it's related to sampling?

We want unsampled metrics. The goal is to get back to the experience of ye olde Honeycomb boards -- an unsampled view for total concurrent GETs and total concurrent POSTs.

While we're doing that, we also need to do the original aim of this ticket:

Now that Freddie is on lantern-cloud, his metrics are reporting to Datadog (as opposed to Honeycomb). We should be namespacing his metric names. I don't really know what that means, but I know it's a thing we should do.

Crosse commented 10 months ago

The simplest thing to do is to rename the counters here by prefixing freddie. so that they become freddie.concurrent_get_reqs and freddie.concurrent_post_req. Although another possibility would be freddie.requests.concurrent.get and freddie.requests.concurrent.post.