search

getlantern / firetweet

FireTweet for Android powered by Lantern
272 stars 73 forks source link

Adding docs on how to build Firetweet. #123

Closed xiam closed 9 years ago

xiam commented 9 years ago

Closes https://github.com/getlantern/firetweet/issues/115

xiam commented 9 years ago

What do you think, @atavism?

atavism commented 9 years ago

@xiam Looks great! Could we add a section that mentions FT integrates Lantern as a shared library that's linked during runtime? Maybe mention the directory the file is located too: src/main/jniLibs/armeabi-v7a/libgojni.so We could also link to the lantern-android project in this section.

xiam commented 9 years ago

Oh, that's a good one! Yeah, completely. Let me do those changes.

On Wednesday, June 3, 2015, atavism notifications@github.com wrote:

@xiam https://github.com/xiam Looks great! Could we add a section that mentions FT integrates Lantern as a shared library that's linked during runtime? Maybe mention the directory the file is located too: src/main/jniLibs/armeabi-v7a/libgojni.so We could also link to the lantern-android project in this section.

— Reply to this email directly or view it on GitHub https://github.com/getlantern/firetweet/pull/123#issuecomment-108668008.

xiam commented 9 years ago

Added a small change on that front @atavism, care to check again?

atavism commented 9 years ago

Great! Thanks a bunch, @xiam.