search

getlantern / firetweet

FireTweet for Android powered by Lantern
272 stars 73 forks source link

FireTweet crashes #147

Closed atavism closed 8 years ago

atavism commented 8 years ago

Hey @uaalto, with your latest changes from https://github.com/getlantern/firetweet/pull/144, and building the library off of valencia, I'm seeing FireTweet crash every time I go to open it. Not seeing anything useful in the log either. Is it working for you?

atavism commented 8 years ago

This is happening when I build from the command line. Note: sometimes I'm able to open the app, but when I click on "Sign In" or "Register" it immediately crashes.

uaalto commented 8 years ago

@atavism This of course didn't happen in my system (both VM and tablet). But it looks just as the insidious https://github.com/getlantern/firetweet/issues/114. I think there is something wrong with the code, such as a race condition, that we didn't manage to catch yet. The gomobile changes didn't modify any functionality in the code (just made a few things private/public), so the problem is definitely not Gomobile. Could you test the Android test app to verify this, please? I'm pretty confident that we have something wrong, or there is a very ugly bug in Go that didn't expose previously in your case but now it does.

However, if you need to develop now, you might better rollback to your version that works before we figure out.

uaalto commented 8 years ago

What's the status of the issue after this PR?

atavism commented 8 years ago

Looks like it was the version of Go we were using after all. That PR fixes the issue I was having,@uaalto. Thanks!

myleshorton commented 8 years ago

Great work guys! Out of curiosity what version of Go should we all be using for this to work? RC1 as of this writing?

uaalto commented 8 years ago

That's the version that seems to solve the issue, yes.