Closed aranhoide closed 9 years ago
coveralls
commented
9 years ago Coverage increased (+0.7%) to 65.62% when pulling 70faf77df87e08f4fac887963bbef4802cc9d00c on multifronting-valencia into a167b752112a9cadb54cd60b2934042ea53dfc76 on valencia.
myleshorton
commented
9 years ago This is kind of impossible to sort through with the AWS-SDK included in the diff. Any way to just add that in a separate PR?
aranhoide
commented
9 years ago @myleshorton : I've just added https://github.com/getlantern/flashlight-build/pull/129 , which is this PR with the AWS and DNSimple bindings removed. Feel free to comment in that one (but when the time comes to merge, please merge this one).
coveralls
commented
9 years ago Coverage increased (+0.71%) to 65.63% when pulling 6feb9b51b62abc3a40f14121c871d1eeb72bd893 on multifronting-valencia into a167b752112a9cadb54cd60b2934042ea53dfc76 on valencia.
coveralls
commented
9 years ago Coverage increased (+0.71%) to 65.63% when pulling ec01b2601eb62f52caf0c08d3e22083d6f45e664 on multifronting-valencia into a167b752112a9cadb54cd60b2934042ea53dfc76 on valencia.
coveralls
commented
9 years ago Coverage increased (+0.71%) to 65.63% when pulling 53ceb195d14c100321eb38e68b5c94dadf8c9827 on multifronting-valencia into a167b752112a9cadb54cd60b2934042ea53dfc76 on valencia.
coveralls
commented
9 years ago Coverage increased (+0.71%) to 65.63% when pulling 6717dd890fe6702c2b00af8422ece1c919458da5 on multifronting-valencia into a167b752112a9cadb54cd60b2934042ea53dfc76 on valencia.
coveralls
commented
9 years ago Coverage increased (+0.71%) to 65.63% when pulling 7f05a1a81ed3ea753ee093435ea572299e42fb6e on multifronting-valencia into a167b752112a9cadb54cd60b2934042ea53dfc76 on valencia.
myleshorton
commented
9 years ago OK, I'm merging this, but I do think we should go back in and tidy up soon.
aranhoide
commented
9 years ago Thanks!
I agree this needs tidying up, and unit tests. If I don't get to it before, this Friday is Quality Day.
[Note: The diff here is quite unworkable because of the AWS and DNSimple bindings. You may want to review (and comment on) https://github.com/getlantern/flashlight-build/pull/129 instead, which is the same as this without these libraries. Please don't merge that one, though.]
This includes the changes in the multifronting PR, plus changes to peerscanner so it can register servers in Cloudfront and in DNSimple (Cloudfront requires that its "distributions" point to domain names, not IPs).
In addition to Cloudflare entries, DNSimple individual (i.e. not round robin) entries are created for all servers. In addition, Cloudfront distributions are created for all servers that report supporting Cloudfront. When we receive a register request from a server that has a Cloudfront distribution set up (these take up to 15 minutes to get ready) we add these entries to the DNSimple roundrobin. We have a bunch of manually created distributions in Cloudfront that point to the DNSimple round robins.
I have tested these with the DO droplets
ps-ara(ip 128.199.40.248, registered asps-test.getiantem.org),fl-nl-ara1(188.166.38.243, serving via HTTPS [edit: as of this writing, this will not really work with Cloudfront, because it's pickier than Cloudflare about self-signed certs]) andfl-nl-ara2(178.62.237.77, serving with-unencryptedon port 80). I tested that these get registered and unregistered (only from the 'groups', particular entries are not unregistered). I had tested the proxying for the multifront PR; nothing has changed in that aspect.There will be a twin PR for the lantern_aws changes required to launch/update these.