Autoupdate code review updates

getlantern / flashlight-build

Repeatable builds for Lantern, using docker.

14 stars 5 forks source link

Autoupdate code review updates #136

Closed oxtoacart closed 9 years ago

oxtoacart commented 9 years ago

Main changes:

Switched to using semantic versioning with semver package
Simplified autoupdate API (which also took care of a race condition or two)
Updated example to show restart after update
Using golog
Slightly more informative error messages in a few places

oxtoacart commented 9 years ago

@xiam - Here are some suggested changes.

coveralls commented 9 years ago

Coverage remained the same at 67.91% when pulling 74b26809b05f54b8464227e3fe14710edd302f2c on feature/autoupdate-ox into 37a6717511e1974e69185d697a59b471ca6c1111 on feature/autoupdate.

xiam commented 9 years ago

@oxtoacart Thank you Ox, looking into it.

xiam commented 9 years ago

Cools suggestions Ox!

oxtoacart commented 9 years ago

Glad you liked them, thanks for reviewing!