search

getlantern / go-natty

Go language wrapper around the natty NAT-traversal utility
Apache License 2.0
36 stars 9 forks source link

Updated to use topics API from waddell #6

Closed oxtoacart closed 9 years ago

aranhoide commented 9 years ago

IIUC this change only touches demo and test code, right?

oxtoacart commented 9 years ago

@aranhoide Yes, this is only demo and test code.

aranhoide commented 9 years ago

Nice. Since go-natty seems small enough I'm reviewing the main code anyway so I understand these changes (and nattywad etc.) better.

oxtoacart commented 9 years ago

@aranhoide That's a good idea, thanks! Your feedback on the main code has already been valuable. Please see PR #9 for my changes addressing your comments.

oxtoacart commented 9 years ago

Also see https://github.com/getlantern/nattywad/pull/3 for the related changes in nattywad.

aranhoide commented 9 years ago

Both go-natty and these changes LGTM, pending the timeout fix (unless I'm wrong about the need for that one). I'll QA this along with related PRs before merging them all.

aranhoide commented 9 years ago

Tests in natty/ pass. Merging as soon as nattywad waddell passes tests too.

oxtoacart commented 9 years ago

@aranhoide Is nattywad failing for you or have you just not run it yet?

aranhoide commented 9 years ago

Sorry, it was a lapsus. I meant waddell. nattywad passes tests.