search

getlantern / go-natty

Go language wrapper around the natty NAT-traversal utility
Apache License 2.0
36 stars 9 forks source link

Code review updates #9

Closed oxtoacart closed 9 years ago

oxtoacart commented 9 years ago

These are updates based on your code review so far. I put them in a branch off of channelwad.

aranhoide commented 9 years ago

LGTM, once the resetting of the timeout is fixed. I'll QA and merge this along with the rest of related PRs.

aranhoide commented 9 years ago

Well, since both these changes and the ones in the parent branch are already reviewed, I'll just merge these, and if you think the timeout fix is warranted you can do it as just a commit in the channelwad branch.