search

getlantern / lantern-client

Lantern Client code
GNU General Public License v3.0
14 stars 3 forks source link

Start up sequence callback #1070

Closed jigar-f closed 5 months ago

jigar-f commented 6 months ago

@atavism Go ahead and review this as well, If all is okay merge this and then put out new build.

atavism commented 6 months ago

Taking a look, @jigar-f!

atavism commented 6 months ago

This is how the VPN switch looks for me on desktop with these changes. Just confirming we want to change the appearance like this?

Before:

image

After:

Screenshot 2024-05-27 at 4 57 21 PM

jigar-f commented 6 months ago

This is how the VPN switch looks for me on desktop with these changes. Just confirming we want to change the appearance like this?

I had to change the switch package due to lack of customization else the UI same. cc @Derekf5 Do you mind checking this UI and letting me know, if these changes look good?

atavism commented 6 months ago

@Derekf5 @jigar-f Are we fine changing the appearance of the VPN switch in the desktop app to look like this? (IMO, it's a little too big). I think that's the main holdup getting this one merged.

image

jigar-f commented 6 months ago

I think Derekf approved these changes last week.

jigar-f commented 6 months ago

Also, @atavism We need to merge flashlight PR before this, I just asked reflog for review on flashlight pr, if all okay we can merge that

atavism commented 6 months ago

I think Derekf approved these changes last week.

Cool, thanks for confirming!

atavism commented 5 months ago

@jigar-f https://github.com/getlantern/flashlight/pull/1387 has been merged and this PR has been updated with the latest changes. OK to merge this now?

jigar-f commented 5 months ago

Cool, let's merge it.

atavism commented 5 months ago

Done!