search

getlantern / lantern-client

Lantern Client code
GNU General Public License v3.0
14 stars 3 forks source link

System tray updates for Windows #1086

Closed atavism closed 6 months ago

atavism commented 6 months ago

Resolves https://github.com/getlantern/engineering/issues/1416

Moves code for managing system tray to separate TrayHandler class and some other improvements

atavism commented 6 months ago

I tested on Windows and confirmed it resolves the issue https://github.com/getlantern/engineering/issues/1416

atavism commented 6 months ago

@atavism Just a couple of comments otherwise LGTM

Thanks! I made those changes (tested on macOS and Windows again) if you wanna take another look

jigar-f commented 6 months ago

@atavism Looks good on macOS.

atavism commented 6 months ago

Looks good on macOS.

Cool, thanks! Merging then..