search

getlantern / lantern-client

Lantern Client code
GNU General Public License v3.0
14 stars 3 forks source link

Open webview in-app instead of a seperate window on macOS and Windows #1198

Closed atavism closed 1 month ago

atavism commented 1 month ago

This PR updates the webview implementation to open the checkout page directly within the app on macOS and Windows, rather than in a separate window. This improves the user experience by keeping navigation seamless and consistent with the rest of the app.

It also includes changes to use webview_windows and some fixes to open the FAQ, forum, and follow us pages in the system browser.

@Derekf5, I know you mentioned opening the webview in a window right next to the main interface. What do you think about opening it directly in-app instead? Here's a video of what it looks like.

https://github.com/user-attachments/assets/be59ba16-21f1-45ea-8b73-5ee94912c296

Derekf5 commented 1 month ago

@atavism that is a nice improvement over my suggestion! How does Shepherd look opened in the webview?

atavism commented 1 month ago

@Derekf5 Here's what Shepherd looks like in the webview on Windows

https://github.com/user-attachments/assets/b517a4cb-a7a0-45ea-a093-4ed7419ba175

Derekf5 commented 1 month ago

perfect, just wanted to make sure the QR code fit in frame without scrolling, thanks @atavism!

atavism commented 1 month ago

I fixed the issue where the app opens with a Broken UI on Windows as well

image