search

getlantern / tlsmasq

A library for servers which masquerade as other TLS servers
Apache License 2.0
2 stars 1 forks source link

Hanging test in master #21

Closed hwh33 closed 3 years ago

hwh33 commented 3 years ago

To reproduce:

Not sure why CI isn't catching this. Ideally, we would figure that out as part of resolving this issue.

This may be an actual logical bug as opposed to a bug in the test itself. It may have been introduced recently as I don't remember seeing this previously. It is definitely happening on v0.4.2. For some reason, this does not seem to happen when running the offending test directly (go test ./ptlshs -count=1000 -run TestPostHandshakeInjection -timeout 10m).

hwh33 commented 3 years ago

Resolved by https://github.com/getlantern/tlsmasq/pull/26.

The TestPostHandshakeInjection output I was seeing may have been a red herring. The real issue may have been this goroutine. Whatever the case, test ./ptlshs -count=1000 was consistently timing out on v0.4.3. It has passed every time I've tried on master, both locally and in CI.