search

getlift / lift

Expanding Serverless Framework beyond functions using the AWS CDK
MIT License
912 stars 111 forks source link

Expose assets bucket name to static-website and single-page-app #311

Closed MarcEspiard closed 1 year ago

MarcEspiard commented 1 year ago

Hi,

Similar to #241, exposing the assets bucket name for the static website and spa constructs. My use case: I want to trigger an event after objects are created in the bucket so a Lambda can add some metadata to each file uploaded in that folder (Cache Control headers etc...)

mnapoli commented 1 year ago

Thanks for opening this PR.

@fredericbarthelet given we merged #241 I think it makes sense to merge this one too (same variable), WDYT?

fredericbarthelet commented 1 year ago

@mnapoli agreed :)

@MarcEspiard, could you update your branch to latest version of master ? We recently shipped a fix that should allow tests with latest version of serverless to pass on your PR :)

MarcEspiard commented 1 year ago

@fredericbarthelet Thank you for that, just updated with latest changes from master. Are you able to do a release after this is merged please? Would really help with the project I'm currently working on.

fredericbarthelet commented 1 year ago

@MarcEspiard published in 1.24.0

Thanks for your contribution :)

MarcEspiard commented 1 year ago

@fredericbarthelet no worries, bonne journée :)