search

getlift / lift

Expanding Serverless Framework beyond functions using the AWS CDK
MIT License
912 stars 111 forks source link

Gracefully handle redirectToMainDomain with only a single domain #321

Closed aran112000 closed 1 year ago

aran112000 commented 1 year ago

We've run into issues with dynamic configs which are stage-dependent - different stages have different domain(s).

This change allows the directive to be present but will silence its behaviour where only a single domain has been specified.

mnapoli commented 1 year ago

The tests are failing, any idea why?

aran112000 commented 1 year ago

The tests are failing, any idea why?

I believe these should all be good to go now :)

mnapoli commented 1 year ago

Thanks!