search

getlift / lift

Expanding Serverless Framework beyond functions using the AWS CDK
MIT License
912 stars 111 forks source link

server-side-website with additional S3 Origin behaviour #325

Open aran112000 opened 1 year ago

aran112000 commented 1 year ago

This adds support to create additional CloudFront Origins & Behaviours so you can map additional paths to alternative, existing S3 buckets.

Includes updated documentation to show how this can be used.

mnapoli commented 1 year ago

Hi, just bumping here regarding my last comment: I think the only thing missing here for a merge are tests? Especially since you discovered plenty of edge cases, maintaining this feature sounds like it will be quite some effort, so the tests will help minimize the effort 😅

aran112000 commented 1 year ago

Hi, just bumping here regarding my last comment: I think the only thing missing here for a merge are tests? Especially since you discovered plenty of edge cases, maintaining this feature sounds like it will be quite some effort, so the tests will help minimize the effort 😅

Sure thing, @robchett just added these now :)

evo-chris commented 1 year ago

@mnapoli Just wondering if there is a plan in mind for the next release and will it include this PR? If there's anything we can help with, let us know. Thanks.

aran112000 commented 10 months ago

Hey @fredericbarthelet, @mnapoli

Any chance this could be reviewed / merged if you're happy with the change & tests added here please?

kevincerro commented 8 months ago

Hope that this will be finally merged. I need to host under a subpath /blog a static-website using a server-side-website construct

vikivyas commented 4 months ago

Aran Reeks (@aran112000) while It is not being approved, how can we use this?

will uploaded files to the bucket be removed on the next deployment?

aran112000 commented 4 months ago

Aran Reeks (@aran112000) while It is not being approved, how can we use this?

will uploaded files to the bucket be removed on the next deployment?

Feel free to use my fork of Lift, we use this on production on a number of sites successfully. It doesn't clear any assets from other buckets on deployment. They're just added as origins to your Cloudfront distributions.

@mnapoli - is it possible to complete the review and get this merged, please?