getlift / lift

Expanding Serverless Framework beyond functions using the AWS CDK
MIT License
912 stars 109 forks source link

Node 20 is not supported #335

Closed dnp1 closed 1 year ago

dnp1 commented 1 year ago

Start from the Use-case

Trying to deploy my serverless using lift, but node 20 is not supported.

Is a real incompatibility or just an unnecessary lock?

Example Config

No response

Implementation Idea

Just update the engines array at package.json maybe will work?

mnapoli commented 1 year ago

Sounds good, you might also want to update the CI here: https://github.com/getlift/lift/blob/master/.github/workflows/ci.yml#L16-L19

dnp1 commented 1 year ago

@mnapoli https://github.com/getlift/lift/pull/336

mnapoli commented 1 year ago

Thank you!