search

getlift / lift

Expanding Serverless Framework beyond functions using the AWS CDK
MIT License
912 stars 109 forks source link

Ignore .DS_Store on s3 sync #346

Open ktwbc opened 1 year ago

ktwbc commented 1 year ago

Start from the Use-case

When using the single-page-app construct on MacOS to deploy from the local folder to S3, if there are any .DS_Store files in the folder as a result of simply going into that folder with Finder, those files are uploaded to S3 too.

There is no reason to sync os-specific files like this. There doesn't appear to be a way to exclude files via a pattern either with this construct. There should be some inherent blacklist for these types of files.

Example Config

No response

Implementation Idea

No response

mnapoli commented 1 year ago

Agreed, I think having this automatically excluded would make sense. Feel free to open a PR!